[libvirt] [PATCH] xen: add QED format test

[Peter Krempa]

On Mon, Dec 19, 2016 at 10:28:55 +0100, Cédric Bosdonnat wrote:
> Follow up of commit 340bb6b7 to add unit tests for the QED format
> support. Also add missing QED case in xenFormatXLDisk()
> ---
>  src/xenconfig/xen_xl.c                                 | 5 +++++
>  tests/xlconfigdata/test-disk-positional-parms-full.cfg | 2 +-
>  tests/xlconfigdata/test-disk-positional-parms-full.xml | 6 ++++++
>  3 files changed, 12 insertions(+), 1 deletion(-)
> 
> diff --git a/src/xenconfig/xen_xl.c b/src/xenconfig/xen_xl.c
> index 048ecd579..65d8ffc63 100644
> --- a/src/xenconfig/xen_xl.c
> +++ b/src/xenconfig/xen_xl.c
> @@ -1050,6 +1050,11 @@ xenFormatXLDisk(virConfValuePtr list, virDomainDiskDefPtr disk)
>          case VIR_STORAGE_FILE_QCOW2:
>              virBufferAddLit(&buf, "qcow2");
>              break;
> +#ifdef LIBXL_HAVE_QED
> +        case VIR_STORAGE_FILE_QED:
> +            virBufferAddLit(&buf, "qed");
> +            break;
> +#endif

This will make the test fail if LIBXL_HAVE_QED is not defined. Also I
don't really see a reason to use the ifdef here as the code can be
compiled without that being defined.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20161219/3529ef54/attachment-0001.sig>