[libvirt] [PATCH 04/89] m4/virt: create result macros for the remaining virt check

Jiri Denemark jdenemar at redhat.com
Mon Dec 19 10:02:05 UTC 2016


On Mon, Dec 19, 2016 at 10:27:05 +0100, Pavel Hrdina wrote:
> On Fri, Dec 16, 2016 at 09:14:56PM +0100, Jiri Denemark wrote:
> > On Fri, Dec 16, 2016 at 21:11:57 +0100, Jiri Denemark wrote:
> > > On Fri, Dec 16, 2016 at 10:10:32 +0100, Pavel Hrdina wrote:
> > > > All checks that prints result at the end of configure uses
> > > > LIBVIRT_RESULT_${CHECK_NAME}.  Create those macros for remaining check.
> > > > 
> > > > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > > > ---
> > > >  configure.ac             | 4 ++--
> > > >  m4/virt-host-validate.m4 | 4 ++++
> > > >  m4/virt-login-shell.m4   | 5 +++++
> > > >  3 files changed, 11 insertions(+), 2 deletions(-)
> > > 
> > > ACK
> > 
> > Actually, my fingers were faster than my brain. Why don't you use
> > LIBVIRT_RESULT rather than AC_MSG_NOTICE.
> 
> I'm planning this as a follow up series that will extend LIBVIRT_RESULT.
> Currently that macro uses only 10 columns for the first part which is not
> enough for all the "Miscellaneous" and "Test suite" results.

Fair enough, ACK.

Jirka




More information about the libvir-list mailing list