[libvirt] [PATCH 10/89] m4/virt-lib: move LIBVIRT_ARG_WITH out of LIBVIRT_CHECK_(LIB|LIB_ALT|PKG)

Jiri Denemark jdenemar at redhat.com
Mon Dec 19 13:52:32 UTC 2016


On Fri, Dec 16, 2016 at 10:10:38 +0100, Pavel Hrdina wrote:
> Following patch will update LIBVIRT_CHECK_(LIB|LIB_ALT|PKG) macros in
> a way that you will be able to call a another macro as a fallback if
> the first one fails.  To allow that, we need to move the
> LIBVIRT_ARG_WITH out of those macro to not have two or more same lines
> in output of "configure --help".
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
...
> diff --git a/m4/virt-lib.m4 b/m4/virt-lib.m4
> index 473d184880..7d7e597b66 100644
> --- a/m4/virt-lib.m4
> +++ b/m4/virt-lib.m4
> @@ -54,7 +54,6 @@ AC_DEFUN([LIBVIRT_CHECK_LIB],[
>    m4_pushdef([header_name], [$4])
>  
>    m4_pushdef([check_name_lc], m4_tolower(check_name))
> -  m4_pushdef([check_name_dash], m4_translit(check_name_lc, [_], [-]))

The removal of check_name_dash macros should be done in the patch which
replaced AC_ARG_WITH with LIBVIRT_ARG_WITH. Not a big deal though so
it's up to you if you move it.

ACK

Jirka




More information about the libvir-list mailing list