[libvirt] [PATCH 2/2] qemu: qemuDomainDiskChangeSupported: Add missing 'address' check

[Michal Privoznik]

On 06.12.2016 15:30, Marc Hartmayer wrote:
> Disk->info is not live updatable so add a check for this. Otherwise
> libvirt reports success even though no data was updated.
> 
> Signed-off-by: Marc Hartmayer <mhartmay at linux.vnet.ibm.com>
> Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
> Reviewed-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> ---
>  src/qemu/qemu_domain.c | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
> index 4aae14d..5f7cd60 100644
> --- a/src/qemu/qemu_domain.c
> +++ b/src/qemu/qemu_domain.c
> @@ -5165,6 +5165,19 @@ qemuDomainDiskChangeSupported(virDomainDiskDefPtr disk,
>      /* "snapshot" is a libvirt internal field and thus can be changed */
>      /* startupPolicy is allowed to be updated. Therefore not checked here. */
>      CHECK_EQ(transient, "transient", true);
> +
> +    /* Note: For some address types the address auto generation for
> +     * @disk has still not happened at this point (e.g. driver
> +     * specific addresses) therefore we can't catch these possible
> +     * address modifications here. */
> +    if (disk->info.type != VIR_DOMAIN_DEVICE_ADDRESS_TYPE_NONE &&
> +        !virDomainDeviceInfoAddressIsEqual(&disk->info, &orig_disk->info)) {
> +        virReportError(VIR_ERR_OPERATION_UNSUPPORTED,
> +                       _("cannot modify field '%s' of the disk"),
> +                       "address");
> +        return false;
> +    }
> +
>      CHECK_EQ(info.bootIndex, "boot order", true);
>      CHECK_EQ(rawio, "rawio", true);
>      CHECK_EQ(sgio, "sgio", true);
> 

ACK, but I guess other devices suffer the same problem as well. Mind
looking into that?

Michal