[libvirt] [PATCH v2 0/2] Detect misconfiguration between disk bus and disk address

[Michal Privoznik]

On 29.11.2016 13:11, Marc Hartmayer wrote:
> This patch series adds the functionality to detect a misconfiguration
> between disk bus type and disk address type for disks that are using
> the address type virDomainDeviceDriveAddress. It also adds a test for
> it.
> 
> A check for other bus types may be needed. This may require a driver
> specific function, as it is already implemented in
> virDomainDeviceDefPostParse(), for example.
> 
> Changelog:
>  - v1 -> v2:
>    + Use full enumeration of the bus types
>    + Add warning for unexpected bus type
> 
> Marc Hartmayer (2):
>   conf: Detect misconfiguration between disk bus and disk address
>   tests: Add tests for disk configuration validation
> 
>  src/conf/domain_conf.c                             | 56 ++++++++++++++++++++++
>  .../qemuxml2argv-disk-fdc-incompatible-address.xml | 22 +++++++++
>  .../qemuxml2argv-disk-ide-incompatible-address.xml | 23 +++++++++
>  ...qemuxml2argv-disk-sata-incompatible-address.xml | 23 +++++++++
>  ...qemuxml2argv-disk-scsi-incompatible-address.xml | 24 ++++++++++
>  tests/qemuxml2argvtest.c                           |  8 ++++
>  6 files changed, 156 insertions(+)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-fdc-incompatible-address.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-ide-incompatible-address.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-sata-incompatible-address.xml
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-disk-scsi-incompatible-address.xml
> 

ACKed and pushed.

Michal