[libvirt] [PATCH] m4/virt-gnutls: use AC_CHECK_FUNCS to detect availability of functions
Daniel P. Berrange
berrange at redhat.com
Thu Dec 22 09:34:57 UTC 2016
On Thu, Dec 22, 2016 at 10:31:33AM +0100, Pavel Hrdina wrote:
> Sigh, autoconf has AC_CHECK_FUNC and AC_CHECK_FUNCS and both check
> whether some function exists or not. However in addition to the obvious
> difference that the later is able to check multiple functions it also
> defines HAVE_FUNCTION_NAME for each function.
>
> Commit 680d2f49da moved the code to separate file, but also blindly
> changed the macro to AC_CHECK_FUNC without confronting the
> documentation.
>
> Reported-by: John Ferlan <jferlan at redhat.com>
>
> <https://www.redhat.com/archives/libvir-list/2016-December/msg01086.html>
>
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
> m4/virt-gnutls.m4 | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/m4/virt-gnutls.m4 b/m4/virt-gnutls.m4
> index bd861eec5f..77122c1202 100644
> --- a/m4/virt-gnutls.m4
> +++ b/m4/virt-gnutls.m4
> @@ -60,8 +60,8 @@ AC_DEFUN([LIBVIRT_CHECK_GNUTLS],[
>
> OLD_LIBS="$LIBS"
> LIBS="$LIBS $GNUTLS_LIBS"
> - AC_CHECK_FUNC([gnutls_rnd])
> - AC_CHECK_FUNC([gnutls_cipher_encrypt])
> + AC_CHECK_FUNCS([gnutls_rnd])
> + AC_CHECK_FUNCS([gnutls_cipher_encrypt])
> LIBS=$OLD_LIBS
> fi
> ])
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://entangle-photo.org -o- http://search.cpan.org/~danberr/ :|
More information about the libvir-list
mailing list