[libvirt] [PATCH] qemu: Align dump options for watchdog and on_crash events
mprivozn at redhat.com
Mon Feb 1 12:53:04 UTC 2016
On 20.01.2016 13:13, Boris Fiuczynski wrote:
> Having on_crash set to either coredump-destroy or coredump-restart
> creates core dumps with option memory-only in the directory specified
> by auto_dump_path. When a watchdog is triggered with the action dump
> the core dump is also placed into the directory specified by auto_dump_path
> but is created without the option memory-only.
> This patch sets the option memory-only also for core dumps created by the
> watchdog event.
> Signed-off-by: Boris Fiuczynski <fiuczy at linux.vnet.ibm.com>
> Reviewed-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
> Reviewed-by: Stefan Zimmermann <stzi at linux.vnet.ibm.com>
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f429832..88ecf48 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -3894,7 +3894,7 @@ static void processWatchdogEvent(virQEMUDriverPtr driver, virDomainObjPtr vm, in
> case VIR_DOMAIN_WATCHDOG_ACTION_DUMP:
> char *dumpfile;
> - unsigned int flags = 0;
> + unsigned int flags = VIR_DUMP_MEMORY_ONLY;
> if (virAsprintf(&dumpfile, "%s/%s-%u",
Makes sense. We should be consistent.
ACKed and pushed.
More information about the libvir-list