[libvirt] [PATCH v3 2/4] virsh: be consistent with style of loop exit

Peter Krempa pkrempa at redhat.com
Mon Feb 1 13:48:15 UTC 2016


On Wed, Jan 27, 2016 at 13:24:52 +1100, Michael Chapman wrote:
> When waiting for a block job, the various statuses (COMPLETED, READY,
> CANCELED, etc.) should all be treated consistently by having the loop be
> exited with "break". Use "goto cleanup" for the error cases only, when
> no block job status is available.
> 
> Signed-off-by: Michael Chapman <mike at very.puzzling.org>
> ---
>  tools/virsh-domain.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160201/ac528b30/attachment-0001.sig>


More information about the libvir-list mailing list