[libvirt] [PATCH 1/5] cfg.mk: Adjust sc_prohibit_int_ijk to support 'exempt from syntax-check'

Ján Tomko jtomko at redhat.com
Wed Feb 3 09:44:23 UTC 2016


On Tue, Feb 02, 2016 at 04:46:17PM +0100, Erik Skultety wrote:
> There might be cases, like with typed params, where triggering this check isn't
> desirable. But including the whole module in the exception regex is not always
> to right way of doing things. By adding an option to manually disable this check
> on a specific occurrence, the module itself will still be checked against the
> rule.
> ---
>  cfg.mk | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/cfg.mk b/cfg.mk
> index b009b28..9bcbd5d 100644
> --- a/cfg.mk
> +++ b/cfg.mk
> @@ -571,7 +571,8 @@ sc_prohibit_int_index:
>  	  $(_sc_search_regexp)
>  
>  sc_prohibit_int_ijk:
> -	@prohibit='\<(int|unsigned) ([^(=]* )*(i|j|k)\>(\s|,|;)'	\
> +	@prohibit='\<(int|unsigned) ([^(=]* )*(i|j|k)\>(\s|,|;) *\('	\

The prohibit line should be left unchanged.

> +	exclude='exempt from syntax-check'				\

ACK to this change.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160203/64bfc7c6/attachment-0001.sig>


More information about the libvir-list mailing list