[libvirt] [PATCH RFC v2 1/5] conf: add net device prefix to capabilities

[Daniel P. Berrange]

On Wed, Feb 03, 2016 at 09:40:33PM +0000, Joao Martins wrote:
> In the reverted commit d2e5538b1, the libxl driver was changed to copy
> interface names autogenerated by libxl to the corresponding network def
> in the domain's virDomainDef object. The copied name is freed when the
> domain transitions to the shutoff state. But when migrating a domain,
> the autogenerated name is included in the XML sent to the destination
> host.  It is possible an interface with the same name already exists on
> the destination host, causing migration to fail.
> 
> This patch defines a new capability for setting the network device
> prefix that will be used in the driver. Valid prefixes are
> VIR_NET_GENERATED_PREFIX or the one announced by the driver.
> 
> Signed-off-by: Joao Martins <joao.m.martins at oracle.com>
> ---
> Changes since v1:
>  - free netprefix in virCapabilitiesDispose()
> ---
>  src/conf/capabilities.c  | 22 ++++++++++++++++++++++
>  src/conf/capabilities.h  |  4 ++++
>  src/libvirt_private.syms |  1 +
>  3 files changed, 27 insertions(+)

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|