[libvirt] [PATCH v4 6/9] virConnectCloseCallbackDataDispose: remove unnecessary locks

Nikolay Shirokovskiy nshirokovskiy at virtuozzo.com
Fri Feb 5 13:44:35 UTC 2016


We don't need locks in dispose functions as they can only
be run in one thread for given object.
---
 src/datatypes.c | 8 +-------
 1 file changed, 1 insertion(+), 7 deletions(-)

diff --git a/src/datatypes.c b/src/datatypes.c
index 1b95b21..3ea7dff 100644
--- a/src/datatypes.c
+++ b/src/datatypes.c
@@ -182,13 +182,7 @@ void virConnectCloseCallbackDataReset(virConnectCloseCallbackDataPtr close)
 static void
 virConnectCloseCallbackDataDispose(void *obj)
 {
-    virConnectCloseCallbackDataPtr cb = obj;
-
-    virObjectLock(cb);
-
-    virConnectCloseCallbackDataReset(cb);
-
-    virObjectUnlock(cb);
+    virConnectCloseCallbackDataReset(obj);
 }
 
 void virConnectCloseCallbackDataRegister(virConnectCloseCallbackDataPtr close,
-- 
1.8.3.1




More information about the libvir-list mailing list