[libvirt] [PATCH] bhyve: Fix the build

Roman Bogorodskiy bogorodskiy at gmail.com
Sat Feb 6 01:38:25 UTC 2016

  Michal Privoznik wrote:

> After 1036ddadb276e we use bhyveDriverGetCapabilities from other
> sources too, not only from bhyve_driver.c. However, the function
> was static so not properly expose to other files. In order to
> expose it, we need to move couple of #include-s too.
> Then, there has been a copy paste error in
> virBhyveProcessReconnect: s/privconn/data->driver/.

Funny, it seems we had a race again. :-)

I noticed this failure this morning but started working on that only an
hour ago and didn't pull before that, but when got almost the same patch
ready, checked e-mail and saw yours.

The only thing I done differently is that I placed
bhyveDriverGetCapabilities prototype into bhyve_capabilities.h. But
despite similar naming, now when I look at your patch, it seems
bhyve_driver.h is a better logical place for it.

Anyway, it builds fine, thanks for the prompt fix!

> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> Pushed under build breaker rule.
>  src/bhyve/bhyve_driver.c  | 4 +---
>  src/bhyve/bhyve_driver.h  | 5 +++++
>  src/bhyve/bhyve_process.c | 3 ++-
>  3 files changed, 8 insertions(+), 4 deletions(-)

Roman Bogorodskiy

More information about the libvir-list mailing list