[libvirt] [PATCH 7/9] tests: utils: Add PreFormat callback for CompareXML2XML helper

Martin Kletzander mkletzan at redhat.com
Tue Feb 9 15:55:13 UTC 2016


On Thu, Jan 28, 2016 at 03:30:12PM -0500, Cole Robinson wrote:
>This allows individual driver tests to hook in their own code before
>the def is formatted and compared.
>
>We will eventually use this in the qemuxml2xml
>---
> tests/bhyvexml2xmltest.c   | 3 ++-
> tests/genericxml2xmltest.c | 3 ++-
> tests/lxcxml2xmltest.c     | 3 ++-
> tests/qemuxml2xmltest.c    | 6 ++++--
> tests/testutils.c          | 7 ++++++-
> tests/testutils.h          | 6 +++++-
> 6 files changed, 21 insertions(+), 7 deletions(-)
>

Visual ACK to 5-7/9, I can't apply them, but if the test work for you,
then just push them so you don't need to resend them because of those
last two patches again.  However I would like to see 8/9 applied in
order to ACK it.  Unless someone else is will beat me to it.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160209/f6a63a46/attachment-0001.sig>


More information about the libvir-list mailing list