[libvirt] [PATCH v2 4/6] tests: utils: Add PreFormat callback for CompareXML2XML helper

Laine Stump laine at laine.org
Tue Feb 9 20:13:32 UTC 2016

On 02/09/2016 10:59 AM, Cole Robinson wrote:
> This allows individual driver tests to hook in their own code before
> the def is formatted and compared.
> We will eventually use this in the qemuxml2xml
> ---

Oops. I ACKed 5/6 before this one (after looking ahead to see how this 
would be used).

This looks okay, although I'm wondering why you call just the PCI 
address assignment rather than a full postparse callback. Other things 
can happen in there, e.g. auto-adding controllers. We may as well test 
the whole thing.

Still this is a good start at that, so ACK.

More information about the libvir-list mailing list