[libvirt] [PATCH v2 0/3] Check return status for virDomainGraphicsListenSetAddress

John Ferlan jferlan at redhat.com
Wed Feb 10 13:05:50 UTC 2016


v1: http://www.redhat.com/archives/libvir-list/2016-February/msg00428.html

Adjustments since v1:

 * Implement suggestions - created qemuParseCommandLineVnc to handle the
   alloc/free of the 'vnc'... Note: Difference in refactored code is to
   use of "cleanup" instead of "error" and "ret = -1" initializer.

 * Modify the virDomainGraphicsListenSetAddress, to have one call instead
   of two... adjusting the 'val' based on whether find '[' in first char

 * Split out the qemuParseCommandLine{String|Pid} functions into their own
   module along with all the collateral damage that causes.  Pared down the
   list of #includes for new modules by build trial and error.

John Ferlan (3):
  qemu: Introduce qemuParseCommandLineVnc
  qemu: Check return status for virDomainGraphicsListenSetAddress
  qemu: Split the command parsing routines into own module

 po/POTFILES.in                |    1 +
 src/Makefile.am               |    1 +
 src/qemu/qemu_command.c       | 2703 ----------------------------------------
 src/qemu/qemu_command.h       |   28 +-
 src/qemu/qemu_domain.c        |    3 +-
 src/qemu/qemu_driver.c        |    1 +
 src/qemu/qemu_monitor_json.c  |    3 +-
 src/qemu/qemu_parse_command.c | 2744 +++++++++++++++++++++++++++++++++++++++++
 src/qemu/qemu_parse_command.h |   53 +
 tests/qemuargv2xmltest.c      |    2 +-
 10 files changed, 2807 insertions(+), 2732 deletions(-)
 create mode 100644 src/qemu/qemu_parse_command.c
 create mode 100644 src/qemu/qemu_parse_command.h

-- 
2.5.0




More information about the libvir-list mailing list