[libvirt] [PATCH 4/4] conf: snapshot: Avoid autogenerating duplicate snapshot names

Peter Krempa pkrempa at redhat.com
Thu Feb 11 14:40:09 UTC 2016


On Thu, Feb 11, 2016 at 15:24:42 +0100, Erik Skultety wrote:
> On 11/02/16 10:20, Peter Krempa wrote:
> > The snapshot name generator truncates the original file name after a '.'
> > and replaces the suffix with the snapshot name. If two disks source
> > images differ only in the suffix portion, the generated name will be
> > duplicate.
> > 
> > Since this is a corner case just error out stating that a duplicate name
> > was generated. The user can work around this situation by providing
> > the file names explicitly.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1283085
> > ---
> >  src/conf/snapshot_conf.c | 12 ++++++++++++
> >  1 file changed, 12 insertions(+)
> > 
> ...
> 
> ACK

Thanks, I've pushed the series.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160211/f24588b6/attachment-0001.sig>


More information about the libvir-list mailing list