[libvirt] [PATCH] virportallocatortest: Run on linux only
abologna at redhat.com
Fri Feb 12 14:27:54 UTC 2016
On Fri, 2016-02-12 at 14:15 +0100, Michal Privoznik wrote:
> After the rework of mocking of our tests there's the
> virportallocator test failing to link on mingw. Well, it's the
> mocking library actually:
> ../gnulib/lib/.libs/libgnu.a(bind.o): In function `rpl_bind':
> /home/jenkins/libvirt-mingw/build32/gnulib/lib/../../../gnulib/lib/bind.c:33: multiple definition of `rpl_bind'
> mingw/build32/tests/../../tests/virportallocatormock.c:79: first defined here
> I've no idea why this matters to mingw and does not to others.
> Nevertheless, if we make the test linux only the problem goes
> Apparently, our test for RTLD_NEXT is not sufficient because
> mingw32 defines it. Lets put aside for a while fact that it has
> the same value as RTLD_DEFAULT which by description has different
> meaning, shall we?
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> tests/virportallocatormock.c | 6 ++++--
> tests/virportallocatortest.c | 5 +++--
> 2 files changed, 7 insertions(+), 4 deletions(-)
Not a proper solution by any stretch of the imagination, but I'm
afraid that we're currently limiting a bunch of other tests to
Linux only while they would work on other platforms as well...
Let's get the mingw build working again for now: going through
the tests to decide which one should be build for which OS is
another day's job.
Software Engineer - Virtualization Team
More information about the libvir-list