[libvirt] [PATCH v3 0/3] Add capability for text based polkit authentication for virsh

John Ferlan jferlan at redhat.com
Fri Feb 12 17:12:30 UTC 2016

v2: http://www.redhat.com/archives/libvir-list/2016-February/msg00618.html

Adjustments since v2:

 Patch 1 - Change not only the message (as requested), but also use a
           different and new error code (VIR_ERR_AUTH_UNAVAILABLE).

 Patch 2 - Added a check for "if (!isatty(STDIN_FILENO))" 
           Used a new parameter for pkttyagent call - "--notify-fd", which
             is documented as "To get notified when the authentication agent
             has been registered either listen to the Changed D-Bus signal
             or use --notify-fd to pass the number of a file descriptor that
             has been passed to the program. This file descriptor will then
             be closed when the authentication agent has been successfully
             registered.  Followed the systemd mechanism. If it's felt that
             a timeout of -1 is too dangerous, I'd be fine with changing it.

 Patch 3 - Since we now can determine our failure based on err->code, use
             the new VIR_ERR_AUTH_UNAVAILABLE to attempt the AgentCreate.
             Also, since virPolkitAgentCreate now will wait for the agent
             to start before returning, the agentstart counter is removed.

John Ferlan (3):
  polkit: Adjust message when authentication agent isn't found
  util: Introduce API's for Polkit text authentication
  virsh: Add support for text based polkit authentication

 include/libvirt/virterror.h |  3 +-
 src/libvirt_private.syms    |  2 ++
 src/util/virerror.c         |  8 ++++-
 src/util/virpolkit.c        | 85 ++++++++++++++++++++++++++++++++++++++++++---
 src/util/virpolkit.h        |  5 +++
 tests/virpolkittest.c       |  8 +++--
 tools/virsh.c               | 38 +++++++++++++++++---
 tools/virsh.h               |  2 ++
 8 files changed, 138 insertions(+), 13 deletions(-)


More information about the libvir-list mailing list