[libvirt] [PATCH] Spell VMware with a lowercase w

Michal Privoznik mprivozn at redhat.com
Tue Feb 16 11:33:54 UTC 2016


On 15.02.2016 15:38, Ján Tomko wrote:
> Replace all occurrences of VMWare outside the news.
> ---
>  docs/formatdomain.html.in | 2 +-
>  docs/migration.html.in    | 2 +-
>  docs/storage.html.in      | 2 +-
>  libvirt.spec.in           | 2 +-
>  src/util/virerror.c       | 2 +-
>  src/util/virstoragefile.c | 2 +-
>  tools/virsh.c             | 2 +-
>  7 files changed, 7 insertions(+), 7 deletions(-)
> 


> diff --git a/tools/virsh.c b/tools/virsh.c
> index b96dbda..eb84dd0 100644
> --- a/tools/virsh.c
> +++ b/tools/virsh.c
> @@ -550,7 +550,7 @@ virshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED)
>      vshPrint(ctl, " OpenVZ");
>  #endif
>  #ifdef WITH_VMWARE
> -    vshPrint(ctl, " VMWare");
> +    vshPrint(ctl, " VMware");
>  #endif
>  #ifdef WITH_PHYP
>      vshPrint(ctl, " PHYP");
> 

I'm not sure we can do this. What if there's somebody relying to see
VMWare? e.g.

if [ -z "`virsh -V | grep VMWare`" ]; then
  destroy_the_world();
fi

But maybe I'm too late since you've pushed this.

Michal




More information about the libvir-list mailing list