[libvirt] [PATCH] Spell VMware with a lowercase w

[Ján Tomko]

On Tue, Feb 16, 2016 at 12:33:54PM +0100, Michal Privoznik wrote:
> On 15.02.2016 15:38, Ján Tomko wrote:
> > Replace all occurrences of VMWare outside the news.
> > ---
> >  docs/formatdomain.html.in | 2 +-
> >  docs/migration.html.in    | 2 +-
> >  docs/storage.html.in      | 2 +-
> >  libvirt.spec.in           | 2 +-
> >  src/util/virerror.c       | 2 +-
> >  src/util/virstoragefile.c | 2 +-
> >  tools/virsh.c             | 2 +-
> >  7 files changed, 7 insertions(+), 7 deletions(-)
> > 
> 
> 
> > diff --git a/tools/virsh.c b/tools/virsh.c
> > index b96dbda..eb84dd0 100644
> > --- a/tools/virsh.c
> > +++ b/tools/virsh.c
> > @@ -550,7 +550,7 @@ virshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED)
> >      vshPrint(ctl, " OpenVZ");
> >  #endif
> >  #ifdef WITH_VMWARE
> > -    vshPrint(ctl, " VMWare");
> > +    vshPrint(ctl, " VMware");
> >  #endif
> >  #ifdef WITH_PHYP
> >      vshPrint(ctl, " PHYP");
> > 
> 
> I'm not sure we can do this. What if there's somebody relying to see
> VMWare? e.g.

This output is meant for human consumption and should not change
unless you do the compilation by hand. I don't see a reason to check
it automatically.

> 
> if [ -z "`virsh -V | grep VMWare`" ]; then
>   destroy_the_world();
> fi
> 

Then it's the end of the world as we know it.

> But maybe I'm too late since you've pushed this.
> 

Changes can be undone too.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160216/68f1d1b4/attachment-0001.sig>