[libvirt] [PATCH 08/12] qemu-command: Move qemuDomain*Address* functions to qemu_domain.c

Ján Tomko jtomko at redhat.com
Tue Feb 16 13:58:15 UTC 2016

On Mon, Feb 15, 2016 at 02:37:22PM -0500, John Ferlan wrote:
> Move the functions into qemu_domain.c - additionally move any supporting
> static functions.
> Make qemuDomainSupportsPCI non static.
> Also, move and rename the following:
> qemuSetSCSIControllerModel to qemuDomainSetSCSIControllerModel
> qemuCollectPCIAddress to qemuDomainCollectPCIAddress
> qemuValidateDevicePCISlotsPIIX3 to qemuDomainValidateDevicePCISlotsPIIX3
> qemuAssignDevicePCISlots to qemuDomainAssignDevicePCISlots

Most of these deal with domain addresses and qemu_domain.c is growing
pretty large. I think they deserve a qemu_domain_addr.c module. (On the
other hand, strictly sticking to the qemuDomainAddr prefix will make the
function names too long)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160216/bab63779/attachment-0001.sig>

More information about the libvir-list mailing list