[libvirt] [PATCH 09/12] qemu-command: Move remaining qemuDomain* functions

John Ferlan jferlan at redhat.com
Tue Feb 16 14:40:37 UTC 2016



On 02/16/2016 09:08 AM, Ján Tomko wrote:
> On Mon, Feb 15, 2016 at 02:37:23PM -0500, John Ferlan wrote:
>> Move qemuDomainNetVLAN and qemuDomainDeviceAliasIndex into qemu_domain.c
>>
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>  src/qemu/qemu_command.c | 22 ----------------------
>>  src/qemu/qemu_command.h |  1 -
>>  src/qemu/qemu_domain.c  | 25 +++++++++++++++++++++++++
>>  src/qemu/qemu_domain.h  |  4 ++++
>>  4 files changed, 29 insertions(+), 23 deletions(-)
>>
>> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
>> index f4b9dcd..a37dba6 100644
>> --- a/src/qemu/qemu_command.c
>> +++ b/src/qemu/qemu_command.c
>> @@ -400,28 +400,6 @@ qemuNetworkPrepareDevices(virDomainDefPtr def)
>>      return ret;
>>  }
>>  
>> -static int qemuDomainDeviceAliasIndex(const virDomainDeviceInfo *info,
>> -                                      const char *prefix)
> 
> This one would fit better together with the other Alias functions.
> 

OK - I flipped a coin and it landed on qemu_domain.c ;-)... Also the
existing qemu_assign_alias.c were more assigning not parsing and
fetching a "piece" of the alias.

John




More information about the libvir-list mailing list