[libvirt] [PATCH 09/10] qemu: Reorganize IOThread -object arguments

[Peter Krempa]

On Tue, Feb 16, 2016 at 19:44:19 -0500, John Ferlan wrote:
> Reorganize the module to put all the IOThread argument processing code
> together after the -smp to form a logical order of processing for
> qemuBuildCommandLine working top down in the module.

This is completely misleading including the title. This extracts the
code from the command line builder.

> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_command.c | 56 +++++++++++++++++++++++++++++++++----------------
>  1 file changed, 38 insertions(+), 18 deletions(-)
> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index c90650f..3000e8f 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -1035,6 +1035,42 @@ qemuBuildSmpCommandLine(virCommandPtr cmd,
>  }
>  
>  
> +/** Start IOThread -object arguments */

Wrong comment style.

> +static int
> +qemuBuildIOThreadCommandLine(virCommandPtr cmd,
> +                             const virDomainDef *def,
> +                             virQEMUCapsPtr qemuCaps)
> +{
> +    size_t i;
> +
> +    if (def->niothreadids == 0)
> +        return 0;
> +
> +    if (!virQEMUCapsGet(qemuCaps, QEMU_CAPS_OBJECT_IOTHREAD)) {
> +        virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s",
> +                       _("IOThreads not supported for this QEMU"));
> +        goto error;

No need for the label.

> +    }
> +
> +    /* Create iothread objects using the defined iothreadids list
> +     * and the defined id and name from the list. These may be used
> +     * by a disk definition which will associate to an iothread by

ACK if you correctly state what this patch is doing in the commit
message, fix the comment style and get rid of the error label.

Peter
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160217/a1e92089/attachment-0001.sig>