[libvirt] [PATCH 0/3] domain: AddImplicitControllers in PostParse

Cole Robinson crobinso at redhat.com
Wed Feb 17 17:17:17 UTC 2016


Move virDomainDefAddImplicitControllers to virDomainDefPostParse
so PostParse users don't need to open code it.

Patch #1 makes the change, and adjusts some xen output to match
Patch #2 is an unrelated cleanup, but it will clash with patch #3
Patch #3 drops a now redundant AddImplicitControllers call in
    qemu_parse_command.c, which reorders the test output a bit

Cole Robinson (3):
  domain: add implicit controllers from post parse
  qemu: parse: rename qemuCaps->caps
  qemu: parse: drop redundant AddImplicitControllers

 src/conf/domain_conf.c                                |  7 +++----
 src/qemu/qemu_parse_command.c                         | 19 ++++++++-----------
 src/qemu/qemu_parse_command.h                         |  4 ++--
 tests/qemuargv2xmldata/qemuargv2xml-boot-cdrom.xml    |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-boot-floppy.xml   |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-boot-network.xml  |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-clock-localtime.xml |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-clock-utc.xml     |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-console-compat.xml  |  2 +-
 .../qemuargv2xml-disk-cdrom-empty.xml                 |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-disk-cdrom.xml    |  2 +-
 .../qemuargv2xml-disk-drive-boot-cdrom.xml            |  2 +-
 .../qemuargv2xml-disk-drive-boot-disk.xml             |  2 +-
 .../qemuargv2xml-disk-drive-cache-directsync.xml      |  2 +-
 .../qemuargv2xml-disk-drive-cache-unsafe.xml          |  2 +-
 .../qemuargv2xml-disk-drive-cache-v2-none.xml         |  2 +-
 .../qemuargv2xml-disk-drive-cache-v2-wb.xml           |  2 +-
 .../qemuargv2xml-disk-drive-cache-v2-wt.xml           |  2 +-
 .../qemuargv2xml-disk-drive-error-policy-enospace.xml |  2 +-
 .../qemuargv2xml-disk-drive-error-policy-stop.xml     |  2 +-
 ...gv2xml-disk-drive-error-policy-wreport-rignore.xml |  2 +-
 .../qemuargv2xml-disk-drive-fmt-qcow.xml              |  2 +-
 .../qemuargv2xml-disk-drive-network-nbd-export.xml    |  2 +-
 ...emuargv2xml-disk-drive-network-nbd-ipv6-export.xml |  2 +-
 .../qemuargv2xml-disk-drive-network-nbd-ipv6.xml      |  2 +-
 .../qemuargv2xml-disk-drive-network-nbd-unix.xml      |  2 +-
 .../qemuargv2xml-disk-drive-network-nbd.xml           |  2 +-
 .../qemuargv2xml-disk-drive-network-rbd-auth.xml      |  2 +-
 .../qemuargv2xml-disk-drive-network-rbd-ceph-env.xml  |  2 +-
 .../qemuargv2xml-disk-drive-network-rbd-ipv6.xml      |  2 +-
 .../qemuargv2xml-disk-drive-network-rbd.xml           |  2 +-
 .../qemuargv2xml-disk-drive-network-sheepdog.xml      |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-disk-floppy.xml   |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-disk-many.xml     |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-disk-usb.xml      |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-disk-virtio.xml   |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-disk-xenvbd.xml   |  2 +-
 .../qemuargv2xml-graphics-sdl-fullscreen.xml          |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-graphics-sdl.xml  |  2 +-
 .../qemuargv2xml-graphics-vnc-policy.xml              |  2 +-
 .../qemuargv2xml-graphics-vnc-sasl.xml                |  2 +-
 .../qemuargv2xml-graphics-vnc-socket.xml              |  2 +-
 .../qemuargv2xml-graphics-vnc-tls.xml                 |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-graphics-vnc.xml  |  2 +-
 .../qemuargv2xml-hostdev-pci-address.xml              |  2 +-
 .../qemuargv2xml-hostdev-usb-address.xml              |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-input-usbmouse.xml  |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-input-usbtablet.xml |  2 +-
 .../qemuargv2xml-machine-core-off.xml                 |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-machine-core-on.xml |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-migrate.xml       |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-misc-acpi.xml     |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-misc-disable-s3.xml |  2 +-
 .../qemuargv2xml-misc-disable-suspends.xml            |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-misc-enable-s4.xml  |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-misc-no-reboot.xml  |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-misc-uuid.xml     |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-net-eth-ifname.xml  |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-net-eth.xml       |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-net-user.xml      |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-net-virtio.xml    |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-nographics-vga.xml  |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-nosharepages.xml  |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-parallel-tcp.xml  |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-pseries-disk.xml  |  2 +-
 .../qemuargv2xmldata/qemuargv2xml-qemu-ns-no-env.xml  |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-restore-v2.xml    |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-dev.xml    |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-file.xml   |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-many.xml   |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-pty.xml    |  2 +-
 .../qemuargv2xml-serial-tcp-telnet.xml                |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-tcp.xml    |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-udp.xml    |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-unix.xml   |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-serial-vc.xml     |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-smp.xml           |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-sound.xml         |  2 +-
 tests/qemuargv2xmldata/qemuargv2xml-watchdog.xml      |  2 +-
 tests/sexpr2xmldata/sexpr2xml-fv-autoport.xml         |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-empty-kernel.xml     |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-force-hpet.xml       |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-force-nohpet.xml     |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-localtime.xml        |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-net-netfront.xml     |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-parallel-tcp.xml     |  1 +
 .../sexpr2xmldata/sexpr2xml-fv-serial-dev-2-ports.xml |  1 +
 .../sexpr2xml-fv-serial-dev-2nd-port.xml              |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-file.xml      |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-null.xml      |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-pipe.xml      |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-pty.xml       |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-stdio.xml     |  1 +
 .../sexpr2xmldata/sexpr2xml-fv-serial-tcp-telnet.xml  |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-tcp.xml       |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-udp.xml       |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-serial-unix.xml      |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-sound-all.xml        |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-sound.xml            |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-usbmouse.xml         |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-usbtablet.xml        |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-utc.xml              |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv-v2.xml               |  1 +
 tests/sexpr2xmldata/sexpr2xml-fv.xml                  |  1 +
 tests/sexpr2xmldata/sexpr2xml-no-source-cdrom.xml     |  1 +
 tests/sexpr2xmldata/sexpr2xml-vif-rate.xml            |  1 +
 .../test-fullvirt-direct-kernel-boot-bogus-extra.xml  |  1 +
 .../test-fullvirt-direct-kernel-boot-extra.xml        |  1 +
 .../xlconfigdata/test-fullvirt-direct-kernel-boot.xml |  1 +
 tests/xlconfigdata/test-fullvirt-multiusb.xml         |  1 +
 tests/xlconfigdata/test-new-disk.xml                  |  1 +
 tests/xlconfigdata/test-spice-features.xml            |  1 +
 tests/xlconfigdata/test-spice.xml                     |  1 +
 tests/xlconfigdata/test-vif-rate.xml                  |  1 +
 tests/xmconfigdata/test-escape-paths.xml              |  1 +
 tests/xmconfigdata/test-fullvirt-default-feature.xml  |  1 +
 tests/xmconfigdata/test-fullvirt-force-hpet.xml       |  1 +
 tests/xmconfigdata/test-fullvirt-force-nohpet.xml     |  1 +
 tests/xmconfigdata/test-fullvirt-localtime.xml        |  1 +
 tests/xmconfigdata/test-fullvirt-net-netfront.xml     |  1 +
 tests/xmconfigdata/test-fullvirt-new-cdrom.xml        |  1 +
 tests/xmconfigdata/test-fullvirt-parallel-tcp.xml     |  1 +
 .../xmconfigdata/test-fullvirt-serial-dev-2-ports.xml |  1 +
 .../test-fullvirt-serial-dev-2nd-port.xml             |  1 +
 tests/xmconfigdata/test-fullvirt-serial-file.xml      |  1 +
 tests/xmconfigdata/test-fullvirt-serial-null.xml      |  1 +
 tests/xmconfigdata/test-fullvirt-serial-pipe.xml      |  1 +
 tests/xmconfigdata/test-fullvirt-serial-pty.xml       |  1 +
 tests/xmconfigdata/test-fullvirt-serial-stdio.xml     |  1 +
 .../xmconfigdata/test-fullvirt-serial-tcp-telnet.xml  |  1 +
 tests/xmconfigdata/test-fullvirt-serial-tcp.xml       |  1 +
 tests/xmconfigdata/test-fullvirt-serial-udp.xml       |  1 +
 tests/xmconfigdata/test-fullvirt-serial-unix.xml      |  1 +
 tests/xmconfigdata/test-fullvirt-sound.xml            |  1 +
 tests/xmconfigdata/test-fullvirt-usbmouse.xml         |  1 +
 tests/xmconfigdata/test-fullvirt-usbtablet.xml        |  1 +
 tests/xmconfigdata/test-fullvirt-utc.xml              |  1 +
 tests/xmconfigdata/test-no-source-cdrom.xml           |  1 +
 tests/xmconfigdata/test-pci-devs.xml                  |  1 +
 139 files changed, 149 insertions(+), 93 deletions(-)

-- 
2.5.0




More information about the libvir-list mailing list