[libvirt] [PATCH] qemu: cgroup: fix cgroup permission logic

Bjoern Walk bwalk at linux.vnet.ibm.com
Thu Feb 18 09:19:51 UTC 2016


Fix logic error introduced in commit d6c91b3c which essentially broke
starting any domain.

Signed-off-by: Bjoern Walk <bwalk at linux.vnet.ibm.com>
---
 src/qemu/qemu_cgroup.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
index 53642a1..f3c5fbb 100644
--- a/src/qemu/qemu_cgroup.c
+++ b/src/qemu/qemu_cgroup.c
@@ -65,7 +65,7 @@ qemuSetupImagePathCgroup(virDomainObjPtr vm,
     if (!virCgroupHasController(priv->cgroup, VIR_CGROUP_CONTROLLER_DEVICES))
         return 0;
 
-    if (readonly)
+    if (!readonly)
         perms |= VIR_CGROUP_DEVICE_WRITE;
 
     VIR_DEBUG("Allow path %s, perms: %s",
-- 
2.3.0




More information about the libvir-list mailing list