[libvirt] [PATCH] docs: List possible GIC versions

Andrea Bolognani abologna at redhat.com
Fri Feb 19 17:31:48 UTC 2016


On Fri, 2016-02-19 at 10:56 -0500, John Ferlan wrote:
> 
> On 02/18/2016 10:28 AM, Andrea Bolognani wrote:
> > Recent changes to the handling of GIC version, specifically commit
> > 2a7b11eafb67, have clearly defined what values are acceptable for the
> > version attribute of the <gic> element. Update the documentation
> > accordingly.
> > ---
> >  docs/formatdomain.html.in | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> > 
> > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > index e96798f..faee603 100644
> > --- a/docs/formatdomain.html.in
> > +++ b/docs/formatdomain.html.in
> > @@ -1577,7 +1577,8 @@
> >            Controller instead of APIC in order to handle interrupts.
> >            For example, the 'aarch64' architecture uses
> >            <code>gic</code> instead of <code>apic</code>. The optional
> > -          attribute <code>version</code> specifies the GIC version;
> > +          attribute <code>version</code> specifies the GIC version (one of
> > +          <code>2</code>, <code>3</code> and <code>host</code>);
> 
> Rather than parentheses before the semi-colon of however...
> 
> Consider a sentence after "all hypervisors.":
> 
> Accepted values are <code>2</code>, <code>3</code>, or <code>host</code>).
> 
> ACK with that

Amended and pushed. Thanks.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list