[libvirt] [PATCH] qemu_process: mark auto-generated spice ports as reserved

[Michal Privoznik]

On 18.02.2016 19:17, Pavel Hrdina wrote:
> In case you will specify graphics like this:
> 
> <graphics type='spice' port='-1'/>
> 
> or
> 
> <graphics type='spice' port='-1' tlsPort='6000'/>
> 
> libvirt will automatically add autoport='no'.  This leads to an issue
> that in qemuProcessStop() we don't release that port because we are
> releasing both port if autoport=yes or only port marked as reserved.
> 
> If autoport=no but we request to generate port via '-1' we need to mark
> that port as reserved in order to release it.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1299696
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  src/qemu/qemu_process.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
> index eaf9fea..e7f19a6 100644
> --- a/src/qemu/qemu_process.c
> +++ b/src/qemu/qemu_process.c
> @@ -3694,6 +3694,9 @@ qemuProcessSPICEAllocatePorts(virQEMUDriverPtr driver,
>              goto error;
>  
>          graphics->data.spice.port = port;
> +
> +        if (!graphics->data.spice.autoport)
> +            graphics->data.spice.portReserved = true;
>      }
>  
>      if (needTLSPort || graphics->data.spice.tlsPort == -1) {
> @@ -3708,6 +3711,9 @@ qemuProcessSPICEAllocatePorts(virQEMUDriverPtr driver,
>              goto error;
>  
>          graphics->data.spice.tlsPort = tlsPort;
> +
> +        if (!graphics->data.spice.autoport)
> +            graphics->data.spice.tlsPortReserved = true;
>      }
>  
>      return 0;
> 

ACK

Michal