[libvirt] [PATCH] Miscellaneous for-loop syntax clean-ups

Martin Kletzander mkletzan at redhat.com
Mon Feb 22 13:16:23 UTC 2016


On Mon, Feb 22, 2016 at 12:15:14PM +0100, Michal Privoznik wrote:
>On 22.02.2016 11:29, Martin Kletzander wrote:
>> Checking whether x > 0 before looping over [0..x] items doesn't make
>> sense and multi-line body must have curly brackets around it.
>>
>> Best viewed with '-w'.
>>
>> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>> ---
>>  src/conf/domain_conf.c            | 24 +++++++++++++-------
>>  src/qemu/qemu_capabilities.c      | 30 ++++++++++++------------
>>  src/storage/storage_backend_rbd.c | 48 +++++++++++++++++++--------------------
>>  src/vbox/vbox_common.c            | 14 ++++--------
>>  4 files changed, 58 insertions(+), 58 deletions(-)
>
>ACK
>
>I wonder if we can use Coccinelle to find other occurrences of this pattern.
>

I did that, but we have no place for such files and I'm not sure we want
them in the repo, so I just use it all by myself.  I'd be happy to share
those, though =)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160222/c12a4893/attachment-0001.sig>


More information about the libvir-list mailing list