[libvirt] [PATCH 3/3] qemuBuildCommandLine: Change the condition for -nographics

Michal Privoznik mprivozn at redhat.com
Tue Feb 23 08:49:09 UTC 2016

There's this check when building command line that whenever
domain has no graphics card configured we put -nographics onto
qemu command line. The check is 'if (!def->graphics)'. This
makes coverity think that def->graphics can be NULL, which is
true. But later in the code every access to def->graphics is
guarded by check for def->ngraphics, so no crash occurs. But this
is something that coverity fails to deduct.
In order to shut coverity up lets change the condition to
'if (!def->ngraphics)'.

Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
 src/qemu/qemu_command.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
index 78423e7..854e51c 100644
--- a/src/qemu/qemu_command.c
+++ b/src/qemu/qemu_command.c
@@ -7130,7 +7130,7 @@ qemuBuildCommandLine(virConnectPtr conn,
      * if you ask for nographic. So we have to make sure we override
      * these defaults ourselves...
-    if (!def->graphics) {
+    if (!def->ngraphics) {
         virCommandAddArg(cmd, "-nographic");
         if (cfg->nogfxAllowHostAudio)

More information about the libvir-list mailing list