[libvirt] [PATCH] libxl: small fix in parsing network

Jim Fehlig jfehlig at suse.com
Wed Feb 24 04:45:15 UTC 2016


On 02/23/2016 01:07 AM, Chunyan Liu wrote:
> Signed-off-by: Chunyan Liu <cyliu at suse.com>
> ---
>  src/libxl/libxl_conf.c   | 2 +-
>  src/libxl/libxl_domain.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

I know it is super nit-picking, but ideally this should have been two patches. I
realized that after committing the patch :-).

Regards,
Jim

>
> diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c
> index 5133299..48b8826 100644
> --- a/src/libxl/libxl_conf.c
> +++ b/src/libxl/libxl_conf.c
> @@ -1471,7 +1471,7 @@ libxlMakeNicList(virDomainDefPtr def,  libxl_domain_config *d_config)
>  
>      VIR_SHRINK_N(x_nics, nnics, nnics - nvnics);
>      d_config->nics = x_nics;
> -    d_config->num_nics = nnics;
> +    d_config->num_nics = nvnics;
>  
>      return 0;
>  
> diff --git a/src/libxl/libxl_domain.c b/src/libxl/libxl_domain.c
> index 632acfd..50f7eed 100644
> --- a/src/libxl/libxl_domain.c
> +++ b/src/libxl/libxl_domain.c
> @@ -315,7 +315,7 @@ libxlDomainDeviceDefPostParse(virDomainDeviceDefPtr dev,
>          virDomainHostdevSubsysPCIPtr pcisrc;
>  
>          if (dev->type == VIR_DOMAIN_DEVICE_NET)
> -            hostdev = &(dev->data.net)->data.hostdev.def;
> +            hostdev = &dev->data.net->data.hostdev.def;
>          else
>              hostdev = dev->data.hostdev;
>          pcisrc = &hostdev->source.subsys.u.pci;




More information about the libvir-list mailing list