[libvirt] [PATCH 09/14] secret: Create a 'configFile' in virSecretObj

Daniel P. Berrange berrange at redhat.com
Fri Feb 26 17:09:48 UTC 2016


On Thu, Feb 25, 2016 at 09:03:13AM -0500, John Ferlan wrote:
> This patch removes the need for secretXMLPath. Instead save 'path' during
> loadSecret as 'configFile'. The secretXMLPath is nothing more than an
> open coded virFileBuildPath.  All that code did was concantenate the
> driver->configDir, the UUID of the secret, and the ".xml" suffix to form
> the configFile name which we now will generate and save instead.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/secret/secret_driver.c | 39 ++++++++++++++++++++-------------------
>  1 file changed, 20 insertions(+), 19 deletions(-)

ACK with the followup squashed obviously


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|




More information about the libvir-list mailing list