[libvirt] [PATCH 2/4] xenconfig: produce key=value disk config syntax in xl formatter
Daniel P. Berrange
berrange at redhat.com
Fri Feb 26 17:39:04 UTC 2016
On Tue, Feb 16, 2016 at 02:45:57PM -0700, Jim Fehlig wrote:
> The most formal form of xl disk configuration uses key=value
> syntax to define each configuration item, e.g.
>
> format=raw, vdev=xvda, access=rw, backendtype=phy, target=disksrc
>
> Change the xl disk formatter to produce this syntax, which allows
> target= to contain meta info needed to setup a network-based
> disksrc (e.g. rbd, nbd, iscsi). For details on xl disk config
> format, see $xen-src/docs/misc/xl-disk-configuration.txt
>
> Update the disk config in the tests to use the formal syntax.
> But add tests to ensure disks specified with the positional
> parameter syntax are correctly converted to <disk> XML.
>
> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
> ---
> src/xenconfig/xen_xl.c | 27 ++++++-----
> .../test-disk-positional-parms-full.cfg | 26 +++++++++++
> .../test-disk-positional-parms-full.xml | 54 ++++++++++++++++++++++
> .../test-disk-positional-parms-partial.cfg | 26 +++++++++++
> .../test-disk-positional-parms-partial.xml | 54 ++++++++++++++++++++++
> .../test-fullvirt-direct-kernel-boot.cfg | 2 +-
> tests/xlconfigdata/test-fullvirt-multiusb.cfg | 2 +-
> tests/xlconfigdata/test-new-disk.cfg | 2 +-
> tests/xlconfigdata/test-paravirt-cmdline.cfg | 2 +-
> tests/xlconfigdata/test-paravirt-maxvcpus.cfg | 2 +-
> tests/xlconfigdata/test-spice-features.cfg | 2 +-
> tests/xlconfigdata/test-spice.cfg | 2 +-
> tests/xlconfigdata/test-vif-rate.cfg | 2 +-
> tests/xlconfigtest.c | 2 +
> 14 files changed, 186 insertions(+), 19 deletions(-)
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list