[libvirt] libvirt 1.2.9.3 - test for vircgrouptest fails

Andrea Bolognani abologna at redhat.com
Fri Feb 26 18:32:10 UTC 2016


On Fri, 2016-02-26 at 19:15 +0100, Andrea Bolognani wrote:
> On Fri, 2016-02-26 at 18:54 +0100, Florian Hubold wrote:
> > 
> > Thanks for the previous fix, can I apply this also on top of v1.2.9-maint branch
> > or does it require some subsequent commits from HEAD?
> The fix is self-contained enough that you shouldn't have any
> problem applying it on top of the v1.2.9-maint branch.

Never mind, looks like you're going to either cherry-pick

  commit af1c98e40604e9d3ee6164e01df82e17b99ce562
  Author: Ján Tomko <jtomko at redhat.com>
  Date:   Thu Jan 22 11:54:50 2015 +0100

      Fix virCgroupGetPercpuStats with non-continuous present CPUs
      
      Per-cpu stats are only shown for present CPUs in the cgroups,
      but we were only parsing the largest CPU number from
      /sys/devices/system/cpu/present and looking for stats even for
      non-present CPUs.
      This resulted in:
      internal error: cpuacct parse error

as well or, for a less invasive change, add

  # define SYSFS_CPU_PRESENT "/sys/devices/system/cpu/present"

yourself near the top of the tests/vircgroupmock.c file.

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list