[libvirt] [libvirt-glib][PATCH] libvirt-glib-1.0.pc.in: Correctly mark variable

Martin Kletzander mkletzan at redhat.com
Mon Jan 4 10:59:32 UTC 2016


On Mon, Jan 04, 2016 at 10:58:15AM +0100, Christophe Fergeau wrote:
>Hey,
>
>On Sun, Jan 03, 2016 at 12:49:30PM +0100, Martin Kletzander wrote:
>> On Sat, Jan 02, 2016 at 12:46:30PM +0100, Michal Privoznik wrote:
>> >In the pkg-config file for libvirt-glib we have a typo:
>> >
>> > Libs.private: @LIBVIRT_LIBS @GLIB2_LIBS@
>> >
>> >Noticed the missing '@' after LIBVIRT_LIBS? Well, I just did.
>> >
>> >Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
>> >---
>> >libvirt-glib-1.0.pc.in | 2 +-
>> >1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>>
>> ACK, although it doesn't look like it hurt anyone, ever.  I'm not sure
>> when Libs.private is used, but I haven't managed to convince pkg-config
>> to use it or print it anywhere.
>
>It's used when asking for flags for static linking:
>
>$ pkg-config --static --libs libvirt-glib-1.0
>-lvirt-glib-1.0 @LIBVIRT_LIBS -lglib-2.0 -pthread
>

Oh, thanks, good to know.

>Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160104/7163f1ab/attachment-0001.sig>


More information about the libvir-list mailing list