[libvirt] [PATCH 09/12] tests: qemuxml2xml: Use standard file comparison helpers

Peter Krempa pkrempa at redhat.com
Fri Jan 8 07:09:01 UTC 2016


On Thu, Jan 07, 2016 at 22:50:03 -0500, Cole Robinson wrote:
> This also makes VIR_TEST_REGENERATE_OUTPUT work
> ---
>  tests/qemuxml2xmltest.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/tests/qemuxml2xmltest.c b/tests/qemuxml2xmltest.c
> index f967ceb..e3bd9c2 100644
> --- a/tests/qemuxml2xmltest.c
> +++ b/tests/qemuxml2xmltest.c
> @@ -43,7 +43,7 @@ static int
>  testXML2XMLHelper(const char *inxml,
>                    const char *inXmlData,
>                    const char *outxml,
> -                  const char *outXmlData,
> +                  const char *outXmlData ATTRIBUTE_UNUSED,

Since there are just two callers of this you might as well as remove
this argument rather than making it unused.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160108/5271ab30/attachment-0001.sig>


More information about the libvir-list mailing list