[libvirt] [PATCH] tests: qemuxml2argv: Add tests for USB controller on q35

Martin Kletzander mkletzan at redhat.com
Fri Jan 8 18:05:42 UTC 2016


On Fri, Jan 08, 2016 at 06:54:32PM +0100, Andrea Bolognani wrote:
>---
> .../qemuxml2argv-usb-controller-default-q35.args   | 21 +++++++++++++++++
> .../qemuxml2argv-usb-controller-default-q35.xml    | 27 ++++++++++++++++++++++
> ...argv-usb-controller-default-unavailable-q35.xml | 27 ++++++++++++++++++++++
> .../qemuxml2argv-usb-controller-explicit-q35.args  | 21 +++++++++++++++++
> .../qemuxml2argv-usb-controller-explicit-q35.xml   | 27 ++++++++++++++++++++++
> ...rgv-usb-controller-explicit-unavailable-q35.xml | 27 ++++++++++++++++++++++

You could've just symlinked those '-unavailable' files to the other ones
since they are the same.

Other than that, it looks fine.  And works even with my ppc64 fix on top
of that =).

ACK,

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160108/1181c114/attachment-0001.sig>


More information about the libvir-list mailing list