[libvirt] [PATCH v2 2/2] virDomainGetTime: Deny on RO connections

[Daniel P. Berrange]

On Mon, Jan 11, 2016 at 01:38:14PM +0100, Michal Privoznik wrote:
> We have a policy that if API may end up talking to a guest agent
> it should require RW connection. We don't obey the rule in
> virDomainGetTime().
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/libvirt-domain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
> index 02fc4df..9491845 100644
> --- a/src/libvirt-domain.c
> +++ b/src/libvirt-domain.c
> @@ -10934,6 +10934,7 @@ virDomainGetTime(virDomainPtr dom,
>      virResetLastError();
>  
>      virCheckDomainReturn(dom, -1);
> +    virCheckReadOnlyGoto(dom->conn->flags, error);
>  
>      if (dom->conn->driver->domainGetTime) {
>          int ret = dom->conn->driver->domainGetTime(dom, seconds,

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|