[libvirt] [PATCH v3 11/14] virsh: Have domain-monitor use common "domain" option

John Ferlan jferlan at redhat.com
Mon Jan 11 15:55:51 UTC 2016



On 01/11/2016 08:07 AM, Andrea Bolognani wrote:
> On Sat, 2016-01-09 at 08:36 -0500, John Ferlan wrote:
>> Make use of the common VIRSH_COMMON_OPT_DOMAIN macro for each of the
>> matching '.name = "domain"' command options.
>>  
>> Signed-off-by: John Ferlan <jferlan at redhat.com>
>> ---
>>   tools/virsh-domain-monitor.c | 77 ++++++++------------------------------------
>>   1 file changed, 13 insertions(+), 64 deletions(-)
> 
> Any reason for this and 12/14 not to be squashed into 03/14?
> 

Because these two were done after the original series and they're a
separate source file

> At the very least, I'd expect them to be placed right after
> 03/14 in the series.
> 

I can squash - that's fine.  I think separation is perhaps more
appropriate for "review purposes", but functionally sp

Tks -

John
> ACK to the changes themselves.
> 
> Cheers.
> 
> -- 
> Andrea Bolognani
> Software Engineer - Virtualization Team
> 




More information about the libvir-list mailing list