[libvirt] [PATCH v3 05/14] virsh: Create macro for common "config" option

Andrea Bolognani abologna at redhat.com
Tue Jan 12 09:53:03 UTC 2016


On Tue, 2016-01-12 at 10:41 +0100, Pavel Hrdina wrote:
> 
> Just a question, I know it's to late to change those patches, it's pushed now,
> but why don't we unify the help string for all the commands?  It does the same
> thing for all commands, there is no reason to have different help string for
> some commands.  And I don't think, that it would break anything.

The most commonly used help text is "affect next boot", while eg. the
help text for the 'schedinfo' command is "get/set value to be used on
next boot".

In this case it makes sense to have a different help text, because
the information can not only be set but also retrieved.

That said, if you can come up with a help text that can accurately
describe all situations where the 'config' option is used, I would
certainly not oppose it :)

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list