[libvirt] [PATCHv3 0/3] 'autodeflate' attribute for mememory balloon

Ján Tomko jtomko at redhat.com
Wed Jan 13 12:32:33 UTC 2016


On Tue, Jan 12, 2016 at 10:44:58AM -0500, John Ferlan wrote:
> 
> 
> On 01/08/2016 05:45 AM, Dmitry Andreev wrote:
> > This patch-set adds support for the new feature 'deflate-on-oom'
> > that has been added to the QEMU virtio memory balloon a month ago.
> > This feature lets a guest OS deflate balloon on OOM.
> > 
> > With 'deflate-on-oom' enabled virtio balloon will release
> > it's memory if possible right before an OOM termination of
> > processes.
> > 
> > QEMU commit with the complete feature description:
> > http://git.qemu.org/?p=qemu.git;a=commit;h=e3816255bf4b6377bb405331e2ee0dc14d841b80
> > 
> > v3
> >  * pull head & merge
> >  * reword commit message [1/3] [2/3]
> >  * docs: s/OOM-/Out of Memory / [1/3]
> >  * merge and fix qemu 2.6.0 caps test [2/3]
> >  * s/> 0/ != VIR_TRISTATE_SWITCH_ABSENT/ [3/3]
> > 
> > Dmitry Andreev (3):
> >   conf: introduce 'autodeflate' attribute for memballoon device
> >   qemu: add capability check for memballoon 'deflate-on-oom' feature
> >   qemu: add support of optional 'autodeflate' attribute

> 
> Had to update/merge in recent caps changes...  Also had the same wierd
> problem in domain_conf.c and qemu_command.c w/r/t 'git am -3' merging
> code into wrong place...
> 
> ACK - will push shortly (this was done before freeze, but I only got to
> it today...Prior version only needed minor updates... The default
> setting is to not enable feature, so should be safe.)

That effectively disables the freeze.
https://www.redhat.com/archives/libvir-list/2015-February/msg01079.html

This series is not safe - it introduces an invalid free in the XML
parser, giving the user with a read-write connection a possibility to crash
libvirtd before we get to the ACL checks.

Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20160113/f0e64581/attachment-0001.sig>


More information about the libvir-list mailing list