[libvirt] [PATCH 0/2] Fix problem generating partition names for multipath device

Michal Privoznik mprivozn at redhat.com
Fri Jan 15 15:06:40 UTC 2016


On 08.01.2016 18:09, John Ferlan wrote:
> Originally posted as an RFC:
> 
> http://www.redhat.com/archives/libvir-list/2015-December/msg00200.html

It hasn't gotten much attention, has it? Sorry.

> 
> I've made further adjustments/changes and actually tested in a multipath
> environment configured with the issue.
> 
> For these patches, rather than making a "general" flag for the pool,
> I chose to add an attribute to the <source> 'device'. This way it was
> much more clear what the attribute was affecting.
> 
> Additionally, it turned out that the issue was showing up for both
> 'user_friendly_names' and for custom 'alias' name entries in the
> /etc/multipath.conf file so rather than being a user_friendly_name
> type flag - I just chose to specific state what it was - a way to
> not have the partition separator flag "p" added to the generated name.
> Also it was a bit more difficult to describe the use of the flag
> especially when it was so specific to one backing store type.
> 
> John Ferlan (2):
>   conf: Add storage pool device attribute part_separator
>   storage: Add new flag for libvirt_parthelper
> 
>  docs/formatstorage.html.in                         | 30 ++++++++++++++++++++--
>  docs/schemas/storagepool.rng                       |  5 ++++
>  src/conf/storage_conf.c                            | 26 +++++++++++++++++--
>  src/conf/storage_conf.h                            |  3 ++-
>  src/storage/parthelper.c                           | 15 ++++++++---
>  src/storage/storage_backend_disk.c                 | 11 +++++++-
>  .../pool-disk-device-nopartsep.xml                 | 14 ++++++++++
>  .../pool-disk-device-nopartsep.xml                 | 14 ++++++++++
>  tests/storagepoolxml2xmltest.c                     |  1 +
>  9 files changed, 110 insertions(+), 9 deletions(-)
>  create mode 100644 tests/storagepoolxml2xmlin/pool-disk-device-nopartsep.xml
>  create mode 100644 tests/storagepoolxml2xmlout/pool-disk-device-nopartsep.xml
> 

ACK to both. But I'd push it after the release.

Michal




More information about the libvir-list mailing list