[libvirt] [PATCH 17/34] tests: qemuxml2xml: Order pinning information numerically
John Ferlan
jferlan at redhat.com
Mon Jan 18 16:53:11 UTC 2016
On 01/14/2016 11:27 AM, Peter Krempa wrote:
> A future patch will refactor the storage of the pinning information in a
> way where the ordering will be lost. Order them numerically to avoid
> changing the tests later.
> ---
> tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml | 2 +-
> tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
This change contradicts commit id '7e8feed4'
It should also be closer or a part of whatever future patch changes
things to require a specific order.
John
> diff --git a/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml b/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml
> index c8cc025..00d8bf0 100644
> --- a/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml
> +++ b/tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml
> @@ -10,8 +10,8 @@
> <iothreadpin iothread='2' cpuset='3'/>
> <iothreadpin iothread='1' cpuset='2'/>
> <emulatorpin cpuset='1'/>
> - <vcpupin vcpu='1' cpuset='1'/>
> <vcpupin vcpu='0' cpuset='0'/>
> + <vcpupin vcpu='1' cpuset='1'/>
> <quota>-1</quota>
> <period>1000000</period>
> <shares>2048</shares>
> diff --git a/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml b/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml
> index dc65564..435d0ae 100644
> --- a/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml
> +++ b/tests/qemuxml2xmloutdata/qemuxml2xmlout-cputune-iothreads.xml
> @@ -9,8 +9,8 @@
> <shares>2048</shares>
> <period>1000000</period>
> <quota>-1</quota>
> - <vcpupin vcpu='1' cpuset='1'/>
> <vcpupin vcpu='0' cpuset='0'/>
> + <vcpupin vcpu='1' cpuset='1'/>
> <emulatorpin cpuset='1'/>
> <iothreadpin iothread='1' cpuset='2'/>
> <iothreadpin iothread='2' cpuset='3'/>
>
More information about the libvir-list
mailing list