[libvirt] [PATCH v2 2/2] bhyve: bhyveload: respect boot dev and boot order

[Roman Bogorodskiy]

  Daniel P. Berrange wrote:

> On Sat, Jan 02, 2016 at 11:53:00PM +0300, Roman Bogorodskiy wrote:
> > Make bhyveload respect boot order as specified by os.boot section of the
> > domain XML or by "boot order" for specific devices. As bhyve does not
> > support a real boot order specification right now, it's just about
> > choosing a single device to boot from.
> > ---
> > +    if (boot_dev != -1) {
> > +        /* If boot_dev is set, we return the first device of
> > +         * the request type */
> > +        for (i = 0; i < def->ndisks; i++) {
> > +            if (!virBhyveUsableDisk(conn, def->disks[i]))
> > +                continue;
> > +
> > +            if (def->disks[i]->device == boot_dev)
> > +                match = def->disks[i];
> 
> Don't you need to have a 'break' here, otherwise you'll carry
> on matching against the 2nd, 3rd, ... disk of that type

Oh, yes, you're right, thanks for noticing that.

> ACK with that fix above, since rest looks fine.

Pushed this and the previous one, thanks!

Roman Bogorodskiy