[libvirt] [PATCH 2/2] virt-host-validate: Fix error level for user namespace check

Andrea Bolognani abologna at redhat.com
Mon Jan 25 17:58:45 UTC 2016


On Mon, 2016-01-25 at 16:40 +0100, Pavel Hrdina wrote:
> On Mon, Jan 25, 2016 at 08:23:22AM +0100, Michal Privoznik wrote:
> > > From the code it seems to me that we need user namespace iff
> 
> s/>From/From/

This is fun. The leading ">" is an artifact of escaping, to prevent
(poorly written?) MUAs from mistaking a line starting with "From" in
the body for the From: header.

You would think 'git format-patch', and most importantly 'git am',
would be clever enough to take this into account, but alas they
don't and just pass the commit message through.

> s/iff/if/

Not a typo: "iff" is shortand for "if and only if", and by doing a
quick search in the git log you'll find that there are quite a few
previous instances. Mostly introduced by Michal :)

Cheers.

-- 
Andrea Bolognani
Software Engineer - Virtualization Team




More information about the libvir-list mailing list