[libvirt] [PATCH 2/2] spec: Move virt-admin into its own package

[Daniel P. Berrange]

On Mon, Jul 04, 2016 at 02:33:33PM +0200, Andrea Bolognani wrote:
> On Fri, 2016-07-01 at 12:04 +0200, Michal Privoznik wrote:
> > The new package for the virt-admin binary is libvirt-admin.
> > 
> > Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> > ---
> >  libvirt.spec.in | 16 ++++++++++++++--
> >  1 file changed, 14 insertions(+), 2 deletions(-)
> > 
> > diff --git a/libvirt.spec.in b/libvirt.spec.in
> > index 8d4df50..e55d362 100644
> > --- a/libvirt.spec.in
> > +++ b/libvirt.spec.in
> > @@ -855,6 +855,15 @@ Requires: cyrus-sasl-md5
> >  %description libs
> >  Shared libraries for accessing the libvirt daemon.
> >  
> > +%package admin
> > +Summary: Set of tools to control libvirt daemon
> > +Group: Development/Libraries
> > +Requires: %{name}-libs = %{version}-%{release}
> > +Requires: readline
> > +
> > +%description admin
> > +The client side utilities to control the libvirt daemon.
> > +
> >  %if %{with_wireshark}
> >  %package wireshark
> >  Summary: Wireshark dissector plugin for libvirt RPC transactions
> > @@ -1752,12 +1761,10 @@ exit 0
> >  
> >  %files client
> >  %{_mandir}/man1/virsh.1*
> > -%{_mandir}/man1/virt-admin.1*
> >  %{_mandir}/man1/virt-xml-validate.1*
> >  %{_mandir}/man1/virt-pki-validate.1*
> >  %{_mandir}/man1/virt-host-validate.1*
> >  %{_bindir}/virsh
> > -%{_bindir}/virt-admin
> >  %{_bindir}/virt-xml-validate
> >  %{_bindir}/virt-pki-validate
> >  %{_bindir}/virt-host-validate
> > @@ -1808,6 +1815,11 @@ exit 0
> >  
> >  %config(noreplace) %{_sysconfdir}/sasl2/libvirt.conf
> >  
> > +%files admin
> > +%{_mandir}/man1/virt-admin.1*
> > +%{_bindir}/virt-admin
> > +
> > +
> >  %if %{with_wireshark}
> >  %files wireshark
> >  %{_libdir}/wireshark/plugins/libvirt.so
> 
> ACK with the same caveat as 1/2 ;)
> 
> By the way, should mingw-libvirt.spec.in updated to ship
> the virsh and virt-admin binaries in separate -client and
> -admin packages?

No, the mingw should package is supposed to contain everything
in one package. sub-packages are explicitly not wanted for
mingw


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|