[libvirt] [libvirt-php PATCH 0/3] Fix PHP5 compatibilty issues.

[Michal Privoznik]

On 06.07.2016 23:42, Dawid Zamirski wrote:
> With the patches that landed support for PHP7 some API calls were not
> behaving correctly when compiled against PHP5. The most obvious case
> is where connection to e.g. esx host, libvirt_connect wasn't properly
> reading out credentials from Zeng HashTable which resulted in failure
> to authenticate. This issue was caused mainly be the differnce in
> Zend's implementaion of zend_hash_get_current_data_ex which in PHP7 
> takes a pointer to zval whereas in PHP5 it takes pointer to pointer to
> zval. To address this, the first commit adds macros that abstract away
> such implementation details and the remaining commits make use of that.
> 
> Dawid Zamirski (3):
>   Define macros for looping php hash tables.
>   libvirt_connect: use loop macros to read cred info.
>   use VIRT_FOREACH macros everywhere.
> 
>  src/libvirt-php.c | 205 +++++++++++++++++-------------------------------------
>  src/libvirt-php.h |   6 ++
>  2 files changed, 69 insertions(+), 142 deletions(-)
> 

Thank you,

ACKed and pushed.

Michal