[libvirt] [PATCH 1/2] qemu: Copy complete domain def in qemuDomainDefFormatBuf

[Michal Privoznik]

On 08.07.2016 17:40, Jiri Denemark wrote:
> Playing directly with our live definition, updating it, and reverting it
> back once we are done is very nice and it's quite dangerous too. Let's
> just make a copy of the domain definition if needed and do all tricks on
> the copy.
> 
> https://bugzilla.redhat.com/show_bug.cgi?id=1320470
> 
> Signed-off-by: Jiri Denemark <jdenemar at redhat.com>
> ---
>  src/conf/domain_conf.c | 10 ++++++----
>  src/qemu/qemu_domain.c | 44 ++++++++++++++++++++++++--------------------
>  2 files changed, 30 insertions(+), 24 deletions(-)

It's our own stupidity that we've ever allowed update flags for format
APIs. Now we have to be extra cautious about it and use hacks like this.

ACK though.

Michal