[libvirt] [PATCH 1/5] virStorageEncryptionSecretFree: Don't leak secret lookup definition

[Peter Krempa]

On Sat, Jul 09, 2016 at 10:19:01 +0200, Michal Privoznik wrote:
> When storage secret is parsed in virStorageEncryptionSecretParse(),
> virSecretLookupParseSecret() which allocates some memory. This is
> however never freed.
> 
> ==21711== 134 bytes in 6 blocks are definitely lost in loss record 70 of 85
> ==21711==    at 0x4C29F80: malloc (vg_replace_malloc.c:296)
> ==21711==    by 0xBCA0356: xmlStrndup (in /usr/lib64/libxml2.so.2.9.4)
> ==21711==    by 0xA9F432E: virXMLPropString (virxml.c:479)
> ==21711==    by 0xA9D25B0: virSecretLookupParseSecret (virsecret.c:70)
> ==21711==    by 0xA9D616E: virStorageEncryptionSecretParse (virstorageencryption.c:172)
> ==21711==    by 0xA9D66B2: virStorageEncryptionParseXML (virstorageencryption.c:281)
> ==21711==    by 0xA9D68DF: virStorageEncryptionParseNode (virstorageencryption.c:338)
> ==21711==    by 0xAA12575: virDomainDiskDefParseXML (domain_conf.c:7606)
> ==21711==    by 0xAA2CAC6: virDomainDefParseXML (domain_conf.c:16658)
> ==21711==    by 0xAA2FC75: virDomainDefParseNode (domain_conf.c:17472)
> ==21711==    by 0xAA2FAE4: virDomainDefParse (domain_conf.c:17419)
> ==21711==    by 0xAA2FB72: virDomainDefParseFile (domain_conf.c:17443)
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>  src/util/virstorageencryption.c | 1 +
>  1 file changed, 1 insertion(+)

ACK