[libvirt] [PATCH V2] systemd: fix ready notification on abstract socket
Jim Fehlig
jfehlig at suse.com
Tue Jul 12 20:00:07 UTC 2016
Daniel P. Berrange wrote:
> On Tue, Jul 12, 2016 at 11:07:10AM -0600, Jim Fehlig wrote:
>> At least with systemd v210, NOTIFY_SOCKET is abstact, e.g.
>> @/org/freedesktop/systemd1/notify. sendmsg() fails on such a socket
>> with "Connection refused". The unix(7) man page contains the following
>> details wrt abstract socket addresses
>>
>> abstract: an abstract socket address is distinguished (from a
>> pathname socket) by the fact that sun_path[0] is a null byte
>> ('\0'). The socket's address in this namespace is given by the
>> additional bytes in sun_path that are covered by the specified
>> length of the address structure. (Null bytes in the name have
>> no special significance.)
>>
>> So we need to be more precise about the address length, setting it to
>> the sizeof sa_family_t + length of address copied to sun_path instead
>> of setting it to the sizeof the entire sockaddr_un struct.
>>
>> Resolves: https://bugzilla.opensuse.org/show_bug.cgi?id=987668
>> Signed-off-by: Jim Fehlig <jfehlig at suse.com>
>
> ACK
Thanks, pushed.
Regards,
Jim
More information about the libvir-list
mailing list