[libvirt] [PATCH] qemu: getAutoDumpPath() return value should be dumpfile not domname.
Michal Privoznik
mprivozn at redhat.com
Wed Jul 13 05:23:40 UTC 2016
On 13.07.2016 06:39, Yan Fu wrote:
> Resolves:https://bugzilla.redhat.com/show_bug.cgi?id=1354238
> ---
> src/qemu/qemu_driver.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index f8d9afe..55a5404 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c
> @@ -3869,7 +3869,7 @@ getAutoDumpPath(virQEMUDriverPtr driver,
> timestr));
>
> virObjectUnref(cfg);
> - return domname;
> + return dumpfile;
> }
>
> static void
>
While you are at this, @domname is leaked after this change. Well,
previously dumpfile was leaked :)
So I'm putting VIR_FREE(domname) just before the return statement,
expanding the commit message a bit, ACKing and pushing.
Congratulation on your first libvirt contribution!
Michal
More information about the libvir-list
mailing list